Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block upload if size exceeds capacity #2053

Merged
merged 19 commits into from
Apr 1, 2022
Merged

Block upload if size exceeds capacity #2053

merged 19 commits into from
Apr 1, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Mar 28, 2022 •
edited
Loading

closes #2030

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

Billing

  • Change applied to both files-ui and storage-ui

@render
Copy link

render bot commented Mar 28, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2053.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c90vka7h8vldrp8ol0fg.

@render
Copy link

render bot commented Mar 28, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2053.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c90vkb7h8vldrp8ol0t0.

@FSM1 FSM1 requested review from Tbaut and RyRy79261 and removed request for Tbaut March 28, 2022 18:10
@render
Copy link

render bot commented Mar 28, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2053.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c90vkcfh8vldrp8ol1eg.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Mar 28, 2022
@FSM1 FSM1 requested review from Tbaut, asnaith and tanmoyAtb and removed request for RyRy79261 March 28, 2022 18:11
@FSM1 FSM1 self-assigned this Mar 28, 2022
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label Mar 28, 2022
@FSM1 FSM1 changed the title Feat/block upload if space exceeded 2030 Block upload if size exceeds capacity Mar 29, 2022
@asnaith
Copy link
Member

asnaith commented Mar 30, 2022

I'm not able to upload enough files to test this at the moment but I check again later once the current upload issue is resolved.

Hopefully, I can intercept and stub the capacity in charles and avoid the need to upload 20gb worth of data.

@FSM1
Copy link
Contributor Author

FSM1 commented Mar 31, 2022

I'm not able to upload enough files to test this at the moment but I check again later once the current upload issue is resolved.

Hopefully, I can intercept and stub the capacity in charles and avoid the need to upload 20gb worth of data.

Should be easy enough to intercept the GET bucket summary call in the tests and test it out that way.

tanmoyAtb
tanmoyAtb reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Tried all the ways we can upload.

Made me think about this.
Whats our policy if the shared folder owner is not the current user ?
I see that shared users with edit access can upload without any restriction.

@tanmoyAtb
Copy link
Contributor

Looks great ! Tried all the ways we can upload.

Made me think about this. Whats our policy if the shared folder owner is not the current user ? I see that shared users with edit access can upload without any restriction.

Ahh I saw the reply later. Makes perfect sense.

Tbaut
Tbaut approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's working well. Just left a couple suggestions for readability and a small layout thing.

packages/files-ui/src/Components/Modules/FileBrowsers/UploadFileModal.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/UploadFileModal.tsx Outdated Show resolved Hide resolved
packages/common-components/src/FileInput/FileInput.tsx Outdated Show resolved Hide resolved
FSM1 and others added 6 commits April 1, 2022 12:09
@FSM1 @Tbaut
Update packages/files-ui/src/Components/Modules/FileBrowsers/UploadFi…
d62a18d 
…leModal.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@FSM1 @Tbaut
Update packages/files-ui/src/Components/Modules/FileBrowsers/UploadFi…
6c276a0 
…leModal.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@FSM1 @Tbaut
Update packages/common-components/src/FileInput/FileInput.tsx
bc97775 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@FSM1
Merge branch 'dev' into feat/block-upload-if-space-exceeded-2030
3c7f138
@FSM1
Merge branch 'dev' into feat/block-upload-if-space-exceeded-2030
0a12a1b
@FSM1
fix lint
05801b5
@FSM1 FSM1 enabled auto-merge April 1, 2022 10:43
@FSM1 FSM1 merged commit 843285b into dev Apr 1, 2022
@FSM1 FSM1 deleted the feat/block-upload-if-space-exceeded-2030 branch April 1, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show an informative message when selecting files that will reach the storage limit
5 participants
@FSM1 @asnaith @tanmoyAtb @Tbaut @actions-user